From c1a476508beb4e9e0cc3f67624996be67f216931 Mon Sep 17 00:00:00 2001 From: jnylen Date: Tue, 23 Apr 2019 09:02:35 +0200 Subject: [PATCH 1/6] Require a string to be passed --- lib/xler.ex | 8 ++++++-- mix.exs | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/xler.ex b/lib/xler.ex index 8327c89..07d63a3 100644 --- a/lib/xler.ex +++ b/lib/xler.ex @@ -14,7 +14,8 @@ defmodule Xler do {:ok, ["Sheet 1"]} """ - def worksheets(filename), do: filename |> Native.worksheets() + def worksheets(filename) when is_binary(filename), do: filename |> Native.worksheets() + def worksheets(_), do: {:error, "not a string"} @doc """ Parses a specific worksheet from a file @@ -27,5 +28,8 @@ defmodule Xler do {:ok, [["Date", "Text"]]} """ - def parse(filename, worksheet), do: filename |> Native.parse(worksheet) + def parse(filename, worksheet) when is_binary(filename) and is_binary(worksheet), + do: filename |> Native.parse(worksheet) + + def worksheets(_, _), do: {:error, "not a string"} end diff --git a/mix.exs b/mix.exs index 285645a..2370bef 100644 --- a/mix.exs +++ b/mix.exs @@ -4,7 +4,7 @@ defmodule Xler.MixProject do def project do [ app: :xler, - version: "0.1.0", + version: "0.2.0", elixir: "~> 1.8", start_permanent: Mix.env() == :prod, compilers: [:rustler] ++ Mix.compilers(), From ae9e964af32411615b8aaa71844c0fdfb84de21e Mon Sep 17 00:00:00 2001 From: jnylen Date: Tue, 23 Apr 2019 09:05:37 +0200 Subject: [PATCH 2/6] No Moduledoc --- lib/xler/native.ex | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/xler/native.ex b/lib/xler/native.ex index f478144..034146f 100644 --- a/lib/xler/native.ex +++ b/lib/xler/native.ex @@ -1,5 +1,6 @@ defmodule Xler.Native do use Rustler, otp_app: :xler, crate: :xler_native + @moduledoc false def parse(_filename, _worksheet), do: error() def worksheets(_filename), do: error() From 1a1e9c8e3d4a7943bef9ecd1dc7ea41306622f15 Mon Sep 17 00:00:00 2001 From: jnylen Date: Tue, 23 Apr 2019 09:05:58 +0200 Subject: [PATCH 3/6] Up version --- mix.exs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mix.exs b/mix.exs index 2370bef..704c971 100644 --- a/mix.exs +++ b/mix.exs @@ -4,7 +4,7 @@ defmodule Xler.MixProject do def project do [ app: :xler, - version: "0.2.0", + version: "0.2.1", elixir: "~> 1.8", start_permanent: Mix.env() == :prod, compilers: [:rustler] ++ Mix.compilers(), From b0b40af3048562404320bf91021730ac3e25e8a5 Mon Sep 17 00:00:00 2001 From: jnylen Date: Tue, 23 Apr 2019 09:21:00 +0200 Subject: [PATCH 4/6] Up version --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 25f16e9..38c8da0 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ by adding `xler` to your list of dependencies in `mix.exs`: ```elixir def deps do [ - {:xler, "~> 0.1.0"} + {:xler, "~> 0.2.0"} ] end ``` From b4603b66e82ea6ff37b14713cf8178d8447869c0 Mon Sep 17 00:00:00 2001 From: jnylen Date: Tue, 23 Apr 2019 13:05:28 +0200 Subject: [PATCH 5/6] Wrong function name --- lib/xler.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/xler.ex b/lib/xler.ex index 07d63a3..3d358ff 100644 --- a/lib/xler.ex +++ b/lib/xler.ex @@ -31,5 +31,5 @@ defmodule Xler do def parse(filename, worksheet) when is_binary(filename) and is_binary(worksheet), do: filename |> Native.parse(worksheet) - def worksheets(_, _), do: {:error, "not a string"} + def parse(_, _), do: {:error, "not a string"} end From d0c328d86abc3451e6049ff6547755050fab3b82 Mon Sep 17 00:00:00 2001 From: jnylen Date: Tue, 23 Apr 2019 13:05:46 +0200 Subject: [PATCH 6/6] Up version --- mix.exs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mix.exs b/mix.exs index 704c971..0c7f8a6 100644 --- a/mix.exs +++ b/mix.exs @@ -4,7 +4,7 @@ defmodule Xler.MixProject do def project do [ app: :xler, - version: "0.2.1", + version: "0.2.2", elixir: "~> 1.8", start_permanent: Mix.env() == :prod, compilers: [:rustler] ++ Mix.compilers(),